Coverage for persistence/client/bean #6404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relatively simple but not-great-testability code. Proper dependency injection would go a long way to helping. While writing this I found one `Close()` not being called (again, dependency injection with a lifecycle would have taken care of this). That's now fixed, though I assume it doesn't actually matter outside of synthetic environments like tests.
Groxx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Groxx
commented
Oct 24, 2024
Comment on lines
+347
to
+349
| // mock-equality helper because `assert.Equal` considers all mocks of the same type to be equal, | ||
| // as they (generally) use the same mock controller and recorder, and it ignores different pointers | ||
| // due to using reflect.DeepEqual. |
There was a problem hiding this comment.
an awkward discovery.
they're reflect.DeepEqual despite being different instances.
Shaddoll
reviewed
Oct 24, 2024
Shaddoll
approved these changes
Oct 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 17 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
taylanisikdemir
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relatively simple but not-great-testability code.
Proper dependency injection would go a long way to helping.
While writing this I found one
Close()not being called (again, dependency injection with a lifecycle would have taken care of this).That's now fixed, though I assume it doesn't actually matter outside of synthetic environments like tests.