bugfix: parent workflow, when signaling child workflow, can experienc… #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e deadlock, if child workflow, at the same time, is completed.
samarabbas
reviewed
Mar 12, 2018
| @@ -328,26 +328,26 @@ func (t *transferQueueProcessorImpl) processActivityTask(task *persistence.Trans | |||
| if err != nil { | |||
| return err | |||
| } | |||
| defer release() | |||
There was a problem hiding this comment.
Can you immediate call 'defer release()' after acquiring the release object?
There was a problem hiding this comment.
there can be cases when cache is full and context, release being nil, while err not being nil, doing defer release() before error checking can lead to null pointer issue
|
|
||
| release() |
There was a problem hiding this comment.
Can you add a comment on why calling the release here is important.
| workflowTypeName := msBuilder.executionInfo.WorkflowTypeName | ||
| workflowStartTimestamp := msBuilder.executionInfo.StartTimestamp.UnixNano() | ||
| workflowCloseTimestamp := msBuilder.getLastUpdatedTimestamp() | ||
| workflowStatue := getWorkflowExecutionCloseStatus(msBuilder.executionInfo.CloseStatus) |
| @@ -455,16 +456,30 @@ func (t *transferQueueProcessorImpl) processCloseExecution(task *persistence.Tra | |||
| return err | |||
| } | |||
|
|
|||
| isChildWorkflow := msBuilder.hasParentExecution() | |||
| workflowCloseStatus := msBuilder.executionInfo.CloseStatus | |||
| completionEvent, _ := msBuilder.GetCompletionEvent() | |||
There was a problem hiding this comment.
We will unnecessarily deserialize the completionEvent even for execution which does not have a Parent. Can you bring this back with the If check?
samarabbas
approved these changes
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e deadlock, if child workflow, at the same time, is completed.