Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make request cancel workflow idempotent #595

Merged
merged 6 commits into from
Mar 6, 2018
Merged

make request cancel workflow idempotent #595

merged 6 commits into from
Mar 6, 2018

Conversation

wxing1292
Copy link
Contributor

No description provided.

@wxing1292 wxing1292 requested a review from samarabbas March 6, 2018 01:20
wxing1292
wxing1292 commented Mar 6, 2018
View reviewed changes
Copy link
Contributor Author

@wxing1292 wxing1292 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when a workflow is already request cancelled, should we return an failed event or a complete event?
ref: https://github.com/uber/cadence/pull/595/files/c508d292add06e0fa9acdc6f2d2c2b81ba19b621#diff-7c30a38ba1cc686da0ac967c4fc1937eR582

@coveralls
Copy link

coveralls commented Mar 6, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.0007%) to 64.413% when pulling 83d6167 on cancellation into 5782955 on master.

@wxing1292 wxing1292 changed the title persist control in request cancel workflow to database make request cancel workflow idempotent Mar 6, 2018
@wxing1292 wxing1292 merged commit b1a2a0f into master Mar 6, 2018
@wxing1292 wxing1292 deleted the cancellation branch March 6, 2018 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarabbas samarabbas samarabbas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wxing1292 @coveralls @samarabbas