Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert codecov change to block new line changes again #5895

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented Apr 9, 2024

What changed?
Revert codecov change that was introduced to bypass in a refactor pr

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@jakobht jakobht enabled auto-merge (squash) April 9, 2024 12:04
@jakobht jakobht merged commit 65c4017 into cadence-workflow:master Apr 9, 2024
16 of 18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018ec2bb-b3b2-4365-a4ad-536cccc07552

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 42 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.001%) to 67.367%

Files with Coverage Reduction New Missed Lines %
service/matching/matcher.go 1 91.07%
service/history/task/transfer_standby_task_executor.go 2 87.01%
service/matching/taskReader.go 2 84.88%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/persistence/execution_manager.go 2 83.54%
common/task/fifo_task_scheduler.go 2 85.57%
common/membership/hashring.go 2 84.69%
common/persistence/statsComputer.go 2 97.14%
service/history/shard/context.go 9 66.87%
service/history/execution/mutable_state_task_refresher.go 18 61.08%
Totals Coverage Status
Change from base Build 018ec2b7-9fca-4566-b8b6-dc4e1b28aa3b: 0.001%
Covered Lines: 98200
Relevant Lines: 145769

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants