-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added missing unit test for functions in dynamicconfig/config.go #5885
added missing unit test for functions in dynamicconfig/config.go #5885
Conversation
Codecov Report
Additional details and impacted filessee 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018ebef5-a178-47ea-9bdd-1c168fff5d52Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general kindly add to the description all changes, including the refactoring of the contstants file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and prefer to write table tests for same methods but different cases as a better testing standard.
sure, followed this approach as the existing test cases where in this pattern, will follow the table test approach for new tests. |
What changed?
add units tests for functions in dynamicconfig/config.go
Why?
Improve test coverage
How did you test it?
go test
Potential risks
Release notes
Documentation Changes