Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mocks for interfaces and also unit tests for functions used in history handler #5882

Merged
merged 10 commits into from
Apr 6, 2024

Conversation

timl3136
Copy link
Member

@timl3136 timl3136 commented Apr 5, 2024

What changed?
Added mocks for interface and also unit tests for functions used in history handler

Why?
Improve test coverage and stability

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

.gen/go/history/history.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Merging #5882 (b241c0b) into master (3479700) will decrease coverage by 0.41%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head b241c0b differs from pull request most recent head 7bf151d. Consider uploading reports for the commit 7bf151d to get more accurate results

Additional details and impacted files
Files Coverage Δ
common/taskTokenSerializerInterfaces.go 0.00% <ø> (ø)
service/history/events/notifier.go 78.94% <ø> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7b58d0...7bf151d. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 5, 2024

Pull Request Test Coverage Report for Build 018eb0a5-c789-4a11-9244-a5679bd84309

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 46 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.03%) to 67.227%

Files with Coverage Reduction New Missed Lines %
service/matching/taskReader.go 2 84.88%
service/history/execution/mutable_state_task_refresher.go 2 62.03%
service/history/queue/timer_gate.go 3 95.83%
service/history/task/fetcher.go 5 85.57%
service/history/task/transfer_standby_task_executor.go 6 86.19%
service/history/task/cross_cluster_task_processor.go 8 80.79%
service/history/task/task_util.go 20 70.57%
Totals Coverage Status
Change from base Build 018eb09a-ebf9-4f53-a677-082ee6ceb39f: 0.03%
Covered Lines: 98137
Relevant Lines: 145979

💛 - Coveralls

@agautam478 agautam478 enabled auto-merge (squash) April 5, 2024 23:13
@agautam478 agautam478 merged commit 5a0a853 into cadence-workflow:master Apr 6, 2024
17 of 18 checks passed
@timl3136 timl3136 deleted the handler-test branch April 6, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants