Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last methods for nosql_execution_Store.go covered #5868

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

agautam478
Copy link
Contributor

What changed?
Happy paths for all methods in the file are done. Will be working on covering the missed lines from now onwards.

Why?
increase code coverage.

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@agautam478 agautam478 enabled auto-merge (squash) April 4, 2024 20:03
@taylanisikdemir taylanisikdemir disabled auto-merge April 4, 2024 20:51
@agautam478 agautam478 enabled auto-merge (squash) April 4, 2024 21:07
@agautam478 agautam478 merged commit 1f120fd into cadence-workflow:master Apr 4, 2024
18 checks passed
@coveralls
Copy link

coveralls commented Apr 5, 2024

Pull Request Test Coverage Report for Build 018eaafe-9e4a-4311-9097-a9e4de06b869

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 44 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.02%) to 66.265%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/matching/matcher.go 2 90.72%
service/history/queue/timer_gate.go 3 95.83%
common/persistence/statsComputer.go 3 96.07%
service/history/task/transfer_standby_task_executor.go 4 86.19%
common/task/fifo_task_scheduler.go 5 84.54%
service/history/task/fetcher.go 6 85.05%
service/history/task/cross_cluster_task_processor.go 8 80.79%
common/persistence/nosql/nosqlplugin/cassandra/workflow_parsing_utils.go 11 91.74%
Totals Coverage Status
Change from base Build 018eaac3-4342-4613-8e92-81e25686f073: 0.02%
Covered Lines: 96955
Relevant Lines: 146315

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants