Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write more tests for cassandra/domain.go #5867

Conversation

taylanisikdemir
Copy link
Member

What changed?
Adding more tests to cassandra/domain.go

Why?
Improve coverage.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Merging #5867 (12684ae) into master (8fc9382) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head 12684ae differs from pull request most recent head ee2d3da. Consider uploading reports for the commit ee2d3da to get more accurate results

Additional details and impacted files
Files Coverage Δ
.../persistence/nosql/nosqlplugin/cassandra/domain.go 98.85% <100.00%> (+60.85%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fc9382...ee2d3da. Read the comment docs.

@taylanisikdemir taylanisikdemir force-pushed the taylan/domains_remaining_tests branch from ec3d304 to 53b8e66 Compare April 4, 2024 20:39
@taylanisikdemir taylanisikdemir enabled auto-merge (squash) April 4, 2024 21:37
@taylanisikdemir taylanisikdemir force-pushed the taylan/domains_remaining_tests branch 3 times, most recently from f2c804d to 12684ae Compare April 4, 2024 23:06
@taylanisikdemir taylanisikdemir force-pushed the taylan/domains_remaining_tests branch from 12684ae to ee2d3da Compare April 5, 2024 02:58
@taylanisikdemir taylanisikdemir merged commit f414775 into cadence-workflow:master Apr 5, 2024
18 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/domains_remaining_tests branch April 5, 2024 03:23
@coveralls
Copy link

coveralls commented Apr 5, 2024

Pull Request Test Coverage Report for Build 018eac31-c4cd-404e-b346-ae1524af6b92

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 56 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.04%) to 66.514%

Files with Coverage Reduction New Missed Lines %
service/matching/matcher.go 1 91.07%
service/matching/taskReader.go 2 84.88%
common/task/fifo_task_scheduler.go 2 82.47%
common/util.go 2 91.78%
common/persistence/historyManager.go 2 66.67%
service/history/queue/timer_queue_processor_base.go 3 77.82%
service/history/task/transfer_standby_task_executor.go 4 86.19%
service/history/task/fetcher.go 4 86.08%
service/history/execution/mutable_state_task_refresher.go 36 62.03%
Totals Coverage Status
Change from base Build 018eabfc-0f71-4bcd-8f78-10ed5dda57ef: 0.04%
Covered Lines: 97337
Relevant Lines: 146341

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants