Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Rename: Integration test for handler #5865

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

abhishekj720
Copy link
Contributor

What changed?
Integration test for handler: renaming the file

Why?
It is a integration test. Will write the unit test.

How did you test it?
Integration test

Potential risks
No risks.

@abhishekj720 abhishekj720 changed the title Integration test for handler File Rename: Integration test for handler Apr 4, 2024
@abhishekj720 abhishekj720 enabled auto-merge (squash) April 4, 2024 19:46
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Merging #5865 (cbbcc24) into master (0ba2e9c) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head cbbcc24 differs from pull request most recent head 0752764. Consider uploading reports for the commit 0752764 to get more accurate results

Additional details and impacted files

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ba2e9c...0752764. Read the comment docs.

@abhishekj720 abhishekj720 merged commit 7a7f629 into cadence-workflow:master Apr 4, 2024
16 of 18 checks passed
@abhishekj720 abhishekj720 deleted the testh branch April 4, 2024 20:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018eaab0-fc87-4077-b4c4-ff92aaefbd87

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 35 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.009%) to 66.272%

Files with Coverage Reduction New Missed Lines %
service/matching/matcher.go 1 91.07%
service/matching/taskReader.go 2 84.88%
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
common/task/fifo_task_scheduler.go 2 87.63%
common/membership/hashring.go 2 82.23%
common/persistence/historyManager.go 2 66.67%
service/history/queue/timer_queue_processor_base.go 3 77.82%
service/matching/taskListManager.go 3 80.2%
service/history/task/transfer_standby_task_executor.go 4 86.19%
service/history/task/fetcher.go 6 85.05%
Totals Coverage Status
Change from base Build 018eaaaf-ac42-4f44-9bc6-b90f44d2a673: 0.009%
Covered Lines: 96966
Relevant Lines: 146315

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants