You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle deprecated and deleted domains on frontend redirection and add context to panics inside redirection.
What changed?
If a domain is deleted or deprecated, redirecting to the other cluster is pointless. So, it should be safe to return an error.
Also, redirection can panic if the domain has an active cluster that is not currently connected to the cluster. I've added domain information to the panic message so it will be easier to track offending callers.
Why?
In Uber, we have a lot of clusters, and domains are migrated across them. If a customer is calling to the wrong environment, it causes panic during redirection. We want to:
a. Improve visibility of these failures to identify problematic domains.
b. Deprecate domains that were migrated out to stop it altogether.
How did you test it?
I added a unit test for a deprecated domain case.
Potential risks
The outgoing error for deprecated domain calls can change because the error will now be returned on the frontend without propagating the request to underlying layers.
Release notes
cadence-frontend no longer redirects calls to deprecated domains.
Merging #5863 (a3cdbf3) into master (7a7f629) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 66.66%.
❗ Current head a3cdbf3 differs from pull request most recent head b47ea75. Consider uploading reports for the commit b47ea75 to get more accurate results
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle deprecated and deleted domains on frontend redirection and add context to panics inside redirection.
What changed?
If a domain is deleted or deprecated, redirecting to the other cluster is pointless. So, it should be safe to return an error.
Also, redirection can panic if the domain has an active cluster that is not currently connected to the cluster. I've added domain information to the panic message so it will be easier to track offending callers.
Why?
In Uber, we have a lot of clusters, and domains are migrated across them. If a customer is calling to the wrong environment, it causes panic during redirection. We want to:
a. Improve visibility of these failures to identify problematic domains.
b. Deprecate domains that were migrated out to stop it altogether.
How did you test it?
I added a unit test for a deprecated domain case.
Potential risks
The outgoing error for deprecated domain calls can change because the error will now be returned on the frontend without propagating the request to underlying layers.
Release notes
cadence-frontend no longer redirects calls to deprecated domains.
Documentation Changes