Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for all the methods in utils file #5861

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

agautam478
Copy link
Contributor

What changed?
This PR concludes the tests for all the methods in nosql_execution_Store_util.go file.
There are still some missing lines that I will address to take coverage to 100%

Why?
code coverage increase.

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

@agautam478 agautam478 enabled auto-merge (squash) April 4, 2024 17:37
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Merging #5861 (0e59c94) into master (f5fde92) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 0e59c94 differs from pull request most recent head 9460269. Consider uploading reports for the commit 9460269 to get more accurate results

Additional details and impacted files

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d34cfb...9460269. Read the comment docs.

@agautam478 agautam478 merged commit 7ae6089 into cadence-workflow:master Apr 4, 2024
18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018eaa3c-d2ad-41ea-ae6c-46f5aedd05d3

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 46 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.03%) to 66.222%

Files with Coverage Reduction New Missed Lines %
service/matching/taskReader.go 2 84.88%
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
service/history/task/transfer_active_task_executor.go 2 72.7%
service/matching/taskListManager.go 2 79.7%
service/history/task/transfer_standby_task_executor.go 4 87.42%
service/history/task/fetcher.go 4 86.08%
service/history/execution/mutable_state_task_refresher.go 30 62.03%
Totals Coverage Status
Change from base Build 018eaa35-d8e0-4c02-b11e-97f9473c5726: 0.03%
Covered Lines: 96907
Relevant Lines: 146337

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants