Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for Workflow parsing functions #5860

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

timl3136
Copy link
Member

@timl3136 timl3136 commented Apr 4, 2024

What changed?
Added unit tests for Workflow parsing functions

Why?
Improve test coverage and stability

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

@timl3136 timl3136 enabled auto-merge (squash) April 4, 2024 15:59
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Merging #5860 (3d2cafc) into master (992b219) will increase coverage by 0.11%.
The diff coverage is n/a.

❗ Current head 3d2cafc differs from pull request most recent head b863ef8. Consider uploading reports for the commit b863ef8 to get more accurate results

Additional details and impacted files

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 992b219...b863ef8. Read the comment docs.

@timl3136 timl3136 merged commit f5fde92 into cadence-workflow:master Apr 4, 2024
18 checks passed
@coveralls
Copy link

coveralls commented Apr 5, 2024

Pull Request Test Coverage Report for Build 018eaa0d-1569-4dbc-84d0-b5b1d27b6da6

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 105 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.06%) to 66.152%

Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 87.42%
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/persistence/sql/sqlplugin/postgres/db.go 2 80.0%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/matching/db.go 2 73.23%
service/matching/taskListManager.go 2 79.7%
service/history/execution/mutable_state_util.go 2 78.13%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
Totals Coverage Status
Change from base Build 018ea9fa-e0f9-43b1-99e0-941d8e3527d8: -0.06%
Covered Lines: 96805
Relevant Lines: 146337

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants