Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for cassandra/domain.go #5856

Merged

Conversation

taylanisikdemir
Copy link
Member

What changed?
Adding tests for cassandra/domain.go. There will be a follow up PR for remaining functions.

Why?
Improve coverage

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Merging #5856 (a7dc5fc) into master (4957d34) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head a7dc5fc differs from pull request most recent head 73efa4c. Consider uploading reports for the commit 73efa4c to get more accurate results

Additional details and impacted files
Files Coverage Δ
.../persistence/nosql/nosqlplugin/cassandra/domain.go 38.00% <100.00%> (+38.00%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4957d34...73efa4c. Read the comment docs.

@taylanisikdemir taylanisikdemir enabled auto-merge (squash) April 4, 2024 05:15
@taylanisikdemir taylanisikdemir merged commit de1f696 into cadence-workflow:master Apr 4, 2024
18 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/domain_test branch April 4, 2024 05:21
@coveralls
Copy link

coveralls commented Apr 4, 2024

Pull Request Test Coverage Report for Build 018ea6bd-ed85-4530-b0b0-164da54f27a3

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 53 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.03%) to 66.173%

Files with Coverage Reduction New Missed Lines %
service/matching/taskReader.go 2 84.88%
common/peerprovider/ringpopprovider/config.go 2 81.58%
service/matching/taskListManager.go 2 80.2%
common/membership/hashring.go 2 82.23%
service/history/task/fetcher.go 2 85.57%
common/persistence/historyManager.go 2 66.67%
service/history/queue/timer_queue_processor_base.go 3 77.82%
common/task/fifo_task_scheduler.go 4 80.41%
service/history/task/transfer_standby_task_executor.go 6 86.6%
service/history/task/cross_cluster_task_processor.go 8 80.79%
Totals Coverage Status
Change from base Build 018ea677-2189-462a-8281-b7114ce8049a: 0.03%
Covered Lines: 96836
Relevant Lines: 146337

💛 - Coveralls

timl3136 pushed a commit to timl3136/cadence that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants