Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test cases for more util methods #5854

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

agautam478
Copy link
Contributor

@agautam478 agautam478 commented Apr 3, 2024

What changed?
And more test cases for nosqlutil.

Why?
to increase code coverage.

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

@agautam478 agautam478 enabled auto-merge (squash) April 3, 2024 23:32
@taylanisikdemir taylanisikdemir changed the title Added a minor validationa nd test cases for more util methods Added a minor validation and test cases for more util methods Apr 3, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Merging #5854 (dafbfe5) into master (4957d34) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head dafbfe5 differs from pull request most recent head b142687. Consider uploading reports for the commit b142687 to get more accurate results

Additional details and impacted files

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de1f696...b142687. Read the comment docs.

@agautam478 agautam478 changed the title Added a minor validation and test cases for more util methods Added test cases for more util methods Apr 4, 2024
@agautam478 agautam478 merged commit fa7a643 into cadence-workflow:master Apr 4, 2024
16 of 18 checks passed
@coveralls
Copy link

coveralls commented Apr 4, 2024

Pull Request Test Coverage Report for Build 018ea78f-3898-4009-9e64-b962c2f41664

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 71 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.003%) to 66.152%

Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 87.01%
common/task/parallel_task_processor.go 2 93.06%
service/history/task/transfer_active_task_executor.go 2 72.7%
common/util.go 2 91.78%
service/history/execution/mutable_state_util.go 2 78.13%
service/matching/taskListManager.go 4 79.7%
service/history/task/fetcher.go 4 86.08%
common/persistence/nosql/nosqlplugin/cassandra/workflow_parsing_utils.go 17 88.02%
service/history/execution/mutable_state_task_refresher.go 36 62.03%
Totals Coverage Status
Change from base Build 018ea78a-c1f4-4673-af25-d1c6720f523e: 0.003%
Covered Lines: 96805
Relevant Lines: 146337

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants