Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some validations in the nosql store and new tests #5853

Merged
merged 8 commits into from
Apr 4, 2024

Conversation

agautam478
Copy link
Contributor

What changed?
Added tests for the noswl_execution_store.go.

I noticed that some methods are lacking common validations so added those as well.

Why?
increase code coveration

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@agautam478 agautam478 enabled auto-merge (squash) April 3, 2024 22:53
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

❗ No coverage uploaded for pull request base (master@7ae6089). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 3457fc1 differs from pull request most recent head 3b054a6. Consider uploading reports for the commit 3b054a6 to get more accurate results

Additional details and impacted files
Files Coverage Δ
common/persistence/nosql/nosql_execution_store.go 42.39% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae6089...3b054a6. Read the comment docs.

@agautam478 agautam478 merged commit 6f56ffe into cadence-workflow:master Apr 4, 2024
16 of 18 checks passed
@coveralls
Copy link

coveralls commented Apr 5, 2024

Pull Request Test Coverage Report for Build 018eaa5b-96df-49f4-acde-1dfac5ec8c84

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 61 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.009%) to 66.211%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
service/history/shard/context.go 2 67.47%
common/persistence/sql/sqlplugin/postgres/db.go 2 80.0%
service/frontend/api/handler.go 2 62.05%
common/util.go 2 91.78%
service/matching/matcher.go 2 90.72%
service/matching/taskListManager.go 3 80.2%
common/archiver/filestore/historyArchiver.go 4 80.95%
service/history/task/fetcher.go 4 85.05%
Totals Coverage Status
Change from base Build 018eaa55-3539-45e7-a9eb-d01940ad6490: 0.009%
Covered Lines: 96892
Relevant Lines: 146339

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants