Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for the remaining util methods #5842

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

agautam478
Copy link
Contributor

What changed?
Had to create a new TestNosqlExecutionStoreUtilsExtended to make a more generic test for all the functions.
About 20% of the file is pending and we should reach close to 100% coverage for these tests

Why?
as a part of code coverage week.

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

@agautam478 agautam478 merged commit 1e5311d into cadence-workflow:master Apr 2, 2024
18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018ea09d-9165-418d-af35-c4d26d93f830

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 50 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.02%) to 65.788%

Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 87.01%
service/matching/taskReader.go 2 84.88%
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/frontend/api/handler.go 2 62.05%
service/history/task/transfer_active_task_executor.go 2 72.7%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/archiver/filestore/historyArchiver.go 4 80.95%
service/history/task/fetcher.go 4 85.05%
service/history/execution/mutable_state_task_refresher.go 8 66.77%
Totals Coverage Status
Change from base Build 018ea09a-e4f5-4af7-b8c3-8cd2b97b296f: 0.02%
Covered Lines: 96274
Relevant Lines: 146339

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants