Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Redirect debug information to stderr #5837

Merged

Conversation

3vilhamster
Copy link
Contributor

What changed?
I'm redirecting debug information about fetched workflows to stderr, so that stdout information could be piped to tools like jq.

Why?
Customer reported broken flow

cadence wf lisall --query ... | jq '.[].WorkflowID' -rc

Current print causes broken json output.

How did you test it?
Run local

Potential risks
None

Release notes

Documentation Changes

@3vilhamster 3vilhamster enabled auto-merge (squash) April 5, 2024 11:32
@coveralls
Copy link

coveralls commented Apr 5, 2024

Pull Request Test Coverage Report for Build 018eae06-ff10-42a3-b4bc-e658182d81c0

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • 72 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.04%) to 66.542%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/cli/workflow_commands.go 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
tools/cli/admin_db_decode_thrift.go 1 71.79%
client/history/client.go 2 78.22%
service/history/handler/handler.go 2 49.66%
service/history/execution/mutable_state_util.go 2 78.13%
service/worker/scanner/executor/runq.go 3 85.48%
service/history/queue/timer_gate.go 3 95.83%
service/matching/taskListManager.go 3 80.2%
service/frontend/api/handler.go 4 62.11%
common/task/fifo_task_scheduler.go 5 84.54%
service/history/engine/engineimpl/historyEngine.go 9 68.34%
Totals Coverage Status
Change from base Build 018eac5d-bd6f-4def-be94-1ce67a2eb211: -0.04%
Covered Lines: 97364
Relevant Lines: 146320

💛 - Coveralls

@3vilhamster 3vilhamster merged commit 9551bfe into cadence-workflow:master Apr 5, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants