Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mock object and basic test cases for visibility single manager #5829

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

bowenxia
Copy link
Member

@bowenxia bowenxia commented Apr 1, 2024

What changed?
Add a mock file for visibility store
Add basic test cases for visibility single manager

Why?
for more code coverage

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e9bab-bec5-43fc-9e00-51c75f4a6a24

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 31 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.002%) to 65.273%

Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 86.6%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/history/shard/context.go 2 66.7%
common/task/parallel_task_processor.go 2 93.06%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/matching/db.go 2 73.23%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/log/tag/tags.go 3 50.18%
common/task/fifo_task_scheduler.go 3 84.54%
service/history/queue/timer_queue_processor_base.go 3 77.82%
Totals Coverage Status
Change from base Build 018e9b7b-0946-4a2a-8777-4a7abded2d0f: -0.002%
Covered Lines: 95517
Relevant Lines: 146334

💛 - Coveralls

@bowenxia bowenxia enabled auto-merge (squash) April 1, 2024 22:19
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Merging #5829 (b5b25c9) into master (e651195) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
Files Coverage Δ
common/persistence/data_store_interfaces.go 100.00% <ø> (ø)
common/persistence/visibility_single_manager.go 3.67% <ø> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e651195...b5b25c9. Read the comment docs.

@bowenxia bowenxia merged commit e4bd6d0 into master Apr 1, 2024
21 checks passed
@bowenxia bowenxia deleted the xbowen_visibility_single_manager_unit_test00 branch April 1, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants