Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for cassandra/tasks.go #5828

Merged

Conversation

taylanisikdemir
Copy link
Member

What changed?
Added unit tests for cassandra/tasks.go

Why?
Improve coverage

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Merging #5828 (81f0745) into master (e4bd6d0) will increase coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head 81f0745 differs from pull request most recent head 93bd7bc. Consider uploading reports for the commit 93bd7bc to get more accurate results

Additional details and impacted files
Files Coverage Δ
...mmon/persistence/nosql/nosqlplugin/cassandra/db.go 96.07% <100.00%> (+0.33%) ⬆️
...n/persistence/nosql/nosqlplugin/cassandra/tasks.go 99.19% <100.00%> (+99.19%) ⬆️

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4bd6d0...93bd7bc. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 1, 2024

Pull Request Test Coverage Report for Build 018e9d0a-ea16-438f-9380-4263004d4e85

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 55 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.04%) to 65.342%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/matching/db.go 2 73.23%
service/history/task/transfer_active_task_executor.go 2 72.83%
common/util.go 2 91.78%
service/history/task/fetcher.go 2 85.57%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/log/tag/tags.go 3 50.18%
service/matching/taskReader.go 5 83.55%
service/history/task/cross_cluster_task_processor.go 8 80.79%
Totals Coverage Status
Change from base Build 018e9bcd-d2d9-47d4-85d6-f340468831ee: 0.04%
Covered Lines: 95621
Relevant Lines: 146339

💛 - Coveralls

@davidporter-id-au
Copy link
Member

this snapshotting of real data is really good for readability and understanding what the code does in action

@taylanisikdemir taylanisikdemir enabled auto-merge (squash) April 2, 2024 04:22
@taylanisikdemir taylanisikdemir merged commit c56c124 into cadence-workflow:master Apr 2, 2024
18 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/tasks_ut branch April 2, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants