Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write unit tests for env.go and a few exclusion updates #5827

Conversation

taylanisikdemir
Copy link
Member

What changed?

  • Added unit tests for env.go
  • Update exclusions

Why?
Improve coverage

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Merging #5827 (82fa143) into master (5003ffb) will increase coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files

see 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5003ffb...82fa143. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e9ace-80c8-4841-9fe5-1ddd83554cc5

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.06%) to 65.306%

Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_task_refresher.go 1 71.2%
service/history/task/transfer_standby_task_executor.go 2 87.42%
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
common/task/fifo_task_scheduler.go 2 85.57%
common/persistence/nosql/nosqlplugin/cassandra/workflow_parsing_utils.go 6 88.02%
Totals Coverage Status
Change from base Build 018e8c46-474f-4f6b-80ab-751d576edd29: 0.06%
Covered Lines: 95565
Relevant Lines: 146334

💛 - Coveralls

@taylanisikdemir taylanisikdemir merged commit e651195 into cadence-workflow:master Apr 1, 2024
20 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/exclusions_update branch April 1, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants