-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check time type in custom search attribute #5822
check time type in custom search attribute #5822
Conversation
Codecov Report
Additional details and impacted files
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018e8110-fc74-4bc4-902d-3ffb52429a5bDetails
💛 - Coveralls |
…CustomSearchAttribute
…ttribute' of github.com:uber/cadence into xbowen_pinotQueryValidator_checkTimeTypeInCustomSearchAttribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What changed?
Add a logic to check time type in custom search attribute.
Why?
Previously, if there's a time.Time() type passed in, like CustomDateTimeField = '2024-02-07T15:32:30Z', there'll be an error.
In order to handle this, I converted it before forming the pinot query.
How did you test it?
unit test
Potential risks
Release notes
Documentation Changes