Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pinot response util to exclude closed wf fields when list open #5808

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

neil-xie
Copy link
Member

What changed?
Pinot has default value -1 for CloseTime/CloseStatus when workflow is open

Why?
Bug fix

How did you test it?
Manual test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Merging #5808 (21cfd36) into master (857b007) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 21cfd36 differs from pull request most recent head ac0aed5. Consider uploading reports for the commit ac0aed5 to get more accurate results

Additional details and impacted files
Files Coverage Δ
common/pinot/response_utility.go 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 857b007...ac0aed5. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 21, 2024

Pull Request Test Coverage Report for Build 018e62fb-90c7-415b-9fce-5c1f87251e7e

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 44 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.01%) to 65.372%

Files with Coverage Reduction New Missed Lines %
service/matching/taskGC.go 1 97.37%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
service/history/shard/context.go 2 66.7%
common/persistence/sql/sqlplugin/postgres/db.go 2 80.0%
common/task/fifo_task_scheduler.go 2 82.47%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/util.go 2 91.78%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/log/tag/tags.go 3 50.18%
Totals Coverage Status
Change from base Build 018e62ed-ff77-41e3-9354-d40c17ed808d: 0.01%
Covered Lines: 95560
Relevant Lines: 146178

💛 - Coveralls

Copy link
Member

@bowenxia bowenxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neil-xie neil-xie enabled auto-merge (squash) March 21, 2024 22:01
@neil-xie neil-xie merged commit 7ef2456 into cadence-workflow:master Mar 21, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants