Switch to gci, so we can actually auto-group imports

[Groxx]

If you are conflicting with this PR

I would recommend simply recreating its changes, it is likely to be MUCH simpler.
Before you merge or rebase, do this:

# get these makefile + tool changes
git checkout master -- internal/tools Makefile

# force a re-format
rm .build/fmt
make fmt

# get rid of the from-main changes
git checkout HEAD -- internal/tools Makefile

# now rebase or merge

---

We've finally found a tool that enforces groups, not just sorts them!
Awesome.
Unfortunately it doesn't (currently?) remove unused imports, so we also
still want/need goimports.
Oh well.

[Groxx]

gofancyimports doesn't format, and it conflicts with goimports (which does format).

so now we have "normal" gofmt use.

perhaps we should add -s to the gofmt command? all it's doing at the moment is removing a bunch of redundant types like

- MaxRetentionDays: DynamicInt{
+ MaxRetentionDays: {

some of which are ever-so-slightly odd looking to my eyes, though it follows the same pattern:

- ... map[string]time.Time{clusterName: time.Time{}},
+ ... map[string]time.Time{clusterName: {}},

[3vilhamster]

I guess this is the issues with fancyimports. I wonder how we can use the same logic in IDEs.
Maybe we can create a wrapper that does goimports + fancyimports afterwards?

[Groxx]

to be clear, removing goimports and using gofmt is not a problem. this is just the motivation. gofmt is faster than goimports, and gofancyimports takes care of the imports that gofmt doesn't touch.

[Groxx]

ah, for IDEs: should definitely be possible, though unlike goimports it needs to be in addition to gofmt, it's not a replacement. combining those might require a small wrapper-binary 🤔 . at the very least though, them doing different things does mean that the order doesn't matter, which is good.

though since it's an Analyzer, it should integrate into gopls just fine.

---

a combined-binary might be reasonable to add to gofancyimports, for IDE purposes. GoLand has a "goimports-like" formatting option which acts a lot like this too.

[taylanisikdemir]

After this lands, what should we all use as Format Tool in IDE?

[Groxx]

Just goimports with -local afaict. I honestly disable this though, IDE formatting does funky and incorrect things kinda frequently.

Or the same thing as the makefile does, if you want true stability and it can run arbitrary binaries

[Groxx]

from some side chats: we'll probably bundle a formatter-wrapper to simplify vscode and maybe other tools.

that's a bit easier to discover and fix after it's merged though, so I'm just going to skip it for now.

[Groxx]

similar stuff with gci due to unused-import cleanup, but this does also gofmt so a custom wrapper to run both is probably less needed - IDEs often detect and warn and offer to clean those up separately.

[taylanisikdemir]

thanks for trying this import organizer and making bulk changes!