Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: potential null pointer error in transfer queue processor #541

Merged
merged 2 commits into from
Feb 1, 2018
Merged

bugfix: potential null pointer error in transfer queue processor #541

merged 2 commits into from
Feb 1, 2018

Conversation

wxing1292
Copy link
Contributor

@wxing1292 wxing1292 commented Feb 1, 2018 •
edited
Loading

bugfix: potential null pointer error in transfer queue processor

@wxing1292 wxing1292 requested a review from vancexu February 1, 2018 00:54
madhuravi
madhuravi approved these changes Feb 1, 2018
View reviewed changes
Copy link
Contributor

@madhuravi madhuravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but can you fix the title to be more meaningful? When we are preparing release or looking at commits, it's nice to have a meaningful title for those that don't have the context.

@wxing1292 wxing1292 changed the title bugfix bugfix: potential null pointer error in transfer queue processor Feb 1, 2018
@coveralls
Copy link

coveralls commented Feb 1, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 67.762% when pulling 17842e6 on bugfix into 8cc9319 on master.

@wxing1292 wxing1292 merged commit 051f9de into master Feb 1, 2018
@wxing1292 wxing1292 deleted the bugfix branch February 1, 2018 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vancexu vancexu vancexu approved these changes

@madhuravi madhuravi madhuravi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wxing1292 @coveralls @vancexu @madhuravi