Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChildWorkflow timeout not communicated to parent execution #504

Merged

Conversation

samarabbas
Copy link
Contributor

@samarabbas samarabbas commented Jan 12, 2018

RecordChildWorkflowCompletion is missing handling for child execution
getting timedout event. This results in a empty decision task getting
created without the ChildWorkflowExecutionTimedOut getting recorded in
history.

fixes #503

RecordChildWorkflowCompletion is missing handling for child execution
getting timedout event.  This results in a empty decision task getting
created without the ChildWorkflowExecutionTimedOut getting recorded in
history.
@samarabbas samarabbas self-assigned this Jan 12, 2018
@samarabbas samarabbas requested a review from yiminc-zz January 12, 2018 07:13
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 66.463% when pulling ddb2243 on samarabbas:child-workflow-timeout-fix into 113a644 on uber:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 66.518% when pulling 9d0948b on samarabbas:child-workflow-timeout-fix into 113a644 on uber:master.

@samarabbas samarabbas merged commit 65e165c into cadence-workflow:master Jan 12, 2018
@samarabbas samarabbas deleted the child-workflow-timeout-fix branch January 12, 2018 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parent workflow gets stuck on timeout of Child execution
3 participants