Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Tasklist name on DecisionTaskScheduled history event #499

Merged

Conversation

samarabbas
Copy link
Contributor

When decision goes into retry loop due to DecisionTimeout or
DecisionFailed, and then eventually completes we write incorrect
tasklist name on DecisionTaskScheduledEvent for the transient decisions.
Also DecisionAttempt got incorrected removed due to bad merge, so
putting that back in.

fixes #498

When decision goes into retry loop due to DecisionTimeout or
DecisionFailed, and then eventually completes we write incorrect
tasklist name on DecisionTaskScheduledEvent for the transient decisions.
Also DecisionAttempt got incorrected removed due to bad merge, so
putting that back in.
@samarabbas samarabbas requested a review from yiminc-zz January 10, 2018 00:02
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 66.643% when pulling 2a7bb8a on samarabbas:missing-tasklist-name-on-event into 7a51af2 on uber:master.

@samarabbas samarabbas merged commit 7ca011c into cadence-workflow:master Jan 10, 2018
@samarabbas samarabbas deleted the missing-tasklist-name-on-event branch January 10, 2018 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Tasklist name on DecisionTaskScheduled event
4 participants