Separate history/matching failure metrics from cadence failures #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vancexu
approved these changes
Jan 3, 2018
samarabbas
reviewed
Jan 4, 2018
| @@ -624,6 +626,7 @@ var MetricDefs = map[ServiceIdx]map[int]metricDefinition{ | |||
| TaskRequests: {metricName: "task.requests", metricType: Counter}, | |||
| TaskFailures: {metricName: "task.errors", metricType: Counter}, | |||
| TaskLatency: {metricName: "task.latency", metricType: Counter}, | |||
| HistoryFailures: {metricName: "history.errors", metricType: Counter}, | |||
There was a problem hiding this comment.
Probably you want to have these defined under common as all services needs to emit these counters.
I would also suggest a "client" prefix for these client metric.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cadence Failures are used to determine availability and marking all errors as CadenceFailures were causing availability drops. Created new tags for history/matching that can be tracked independently.