-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass at graceful shutdown handlers #3134
Merged
venkat1109
merged 7 commits into
cadence-workflow:master
from
venkat1109:v_graceful_shutdown
Mar 26, 2020
Merged
First pass at graceful shutdown handlers #3134
venkat1109
merged 7 commits into
cadence-workflow:master
from
venkat1109:v_graceful_shutdown
Mar 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
098e109
to
23321e0
Compare
emrahs
reviewed
Mar 25, 2020
yycptt
reviewed
Mar 25, 2020
yycptt
approved these changes
Mar 25, 2020
dcbe70d
to
01e9f26
Compare
vancexu
approved these changes
Mar 25, 2020
emrahs
approved these changes
Mar 25, 2020
dec5a0f
to
9d0c94b
Compare
9d0c94b
to
1603000
Compare
venkat1109
added a commit
that referenced
this pull request
Mar 27, 2020
venkat1109
added a commit
that referenced
this pull request
Mar 27, 2020
yux0
pushed a commit
that referenced
this pull request
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This patch implements mechanism to gracefully drain traffic during deployments to avoid availability drops. The mechanism varies somewhat based on the role.
The shutdown protocol on some host H looks like the following:
History
Frontend
Matching
Why?
Grace shutdown mechanism is needed to reduce availability dips during deployments
How did you test it?
Tested locally. Also tested on a staging environment.
Potential risks
Graceful shutdown fails to work and there continues to be availability dips during deployment.
A bug in the code causes process to crash during shutdown.
First pass at fixing #1454