Fix cron integration test #2275
Conversation
host/integration_test.go
Outdated
| for i := 1; i != 4; i++ { | ||
| executionInfo := closedExecutions[i] | ||
| executionTime := executionInfo.GetExecutionTime() | ||
| s.Equal(int(0), int(executionTime/1000000000 - firstExecutionTime/1000000000 ) % 3) |
There was a problem hiding this comment.
Can we add a comment here explaining why %3 and /1000000000?
There was a problem hiding this comment.
Also, I think we still need to check the execution time for the first execution, which should be 3s after the start time.
There was a problem hiding this comment.
For the first execution which is the terminated one, the execution time equals to the start time
There was a problem hiding this comment.
I think by first execution, I mean the first run, which should be continued as new.
For the last run, which is terminated, can you explain why the execution time equals to the start time? Am I missing something here?
There was a problem hiding this comment.
When listing closed workflow, the returned execution ordered by increasing close time or decreasing close time? If the first execution is terminated, seems like it's the latter.
There was a problem hiding this comment.
The latter. The first one is the termination and it will verify below
Fix cron integration test