Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable workflow execution first batch deletion #2081

Merged
merged 4 commits into from
Jun 25, 2019
Merged

Disable workflow execution first batch deletion #2081

merged 4 commits into from
Jun 25, 2019

Conversation

wxing1292
Copy link
Contributor

  • Do not delete the first event batch if persistence of mutable state fails
  • Record context deadline exceeds / cancelled error as context timeout metrics

Disable workflow execution first batch deletion
120cc01 
* Do not delete the first event batch if persistence of mutable state fails
* Record context deadline exceeds / cancelled error as context timeout metrics
vancexu
vancexu reviewed Jun 22, 2019
View reviewed changes
Copy link
Contributor

@vancexu vancexu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this change cause event leak?

@wxing1292
Copy link
Contributor Author

Will this change cause event leak?

yes, the thing is, we cannot clearly tell which events can be safely deleted.

@wxing1292 wxing1292 merged commit d2b0df7 into master Jun 25, 2019
@wxing1292 wxing1292 deleted the bugfix branch June 25, 2019 20:16
wxing1292 added a commit that referenced this pull request Jun 25, 2019
@wxing1292
Disable workflow execution first batch deletion (#2081)
4511e16 
* Disable workflow execution first batch deletion
* Do not delete the first event batch if persistence of mutable state fails
* Record context deadline exceeds / cancelled error as context timeout metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vancexu vancexu vancexu left review comments

@meiliang86 meiliang86 meiliang86 approved these changes

@venkat1109 venkat1109 Awaiting requested review from venkat1109

@longquanzheng longquanzheng Awaiting requested review from longquanzheng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wxing1292 @vancexu @meiliang86