Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics to DC redirection handler #2050

Merged
merged 4 commits into from
Jun 17, 2019
Merged

Add metrics to DC redirection handler #2050

merged 4 commits into from
Jun 17, 2019

Conversation

wxing1292
Copy link
Contributor

@wxing1292 wxing1292 commented Jun 17, 2019 •
edited
Loading

solve #2041

@wxing1292 wxing1292 requested a review from vancexu June 17, 2019 21:47
vancexu
vancexu approved these changes Jun 17, 2019
View reviewed changes
service/frontend/dcRedirectionHandler.go Outdated
@@ -885,3 +1038,17 @@ func (handler *DCRedirectionHandlerImpl) TerminateWorkflowExecution(

return err
}

func (handler *DCRedirectionHandlerImpl) beforeCall() time.Time {
return handler.timeSource.Now()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can timeSource be nil?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is initialized in the new function

@wxing1292 wxing1292 force-pushed the dc-redirection-handler-metrics branch from 89b9939 to 6ae2226 Compare June 17, 2019 22:15
@wxing1292 wxing1292 merged commit b52178f into master Jun 17, 2019
@wxing1292 wxing1292 deleted the dc-redirection-handler-metrics branch June 17, 2019 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vancexu vancexu vancexu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wxing1292 @vancexu