Add latency metrics for each visibility message to ES #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Jun 14, 2019
common/metrics/fake.go
Outdated
| @@ -0,0 +1,36 @@ | |||
| // Copyright (c) 2017 Uber Technologies, Inc. | |||
There was a problem hiding this comment.
could you change this file name to noop.go?
wxing1292
reviewed
Jun 14, 2019
| @@ -67,7 +67,7 @@ func (r *replayMetricsClient) AddCounter(scope int, counter int, delta int64) { | |||
| // StartTimer starts a timer for the given metric name. Time will be recorded when stopwatch is stopped. | |||
| func (r *replayMetricsClient) StartTimer(scope int, timer int) tally.Stopwatch { | |||
| if workflow.IsReplaying(r.ctx) { | |||
| return nopStopwatch() | |||
| return metrics.NopStopwatch() | |||
There was a problem hiding this comment.
FYI
In computer science, a NOP, no-op, or NOOP (pronounced "no op"; short for no operation) is an assembly language instruction, programming language statement, or computer protocol command that does nothing.
wxing1292
reviewed
Jun 14, 2019
| @@ -64,6 +65,11 @@ type ( | |||
| logger log.Logger | |||
| metricsClient metrics.Client | |||
| } | |||
|
|
|||
| kafkaMessageWithMetrics struct { // value of esProcessorImpl.mapToKafkaMsg | |||
There was a problem hiding this comment.
you can also make this struct implement messaging.Message and make the implemented ack / nack call stopwatch.stop
There was a problem hiding this comment.
updated, I think your suggestion is cleaner
wxing1292
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also contains a small refactor of archival tests