Refactor reset mutable state API #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wxing1292
commented
Jun 12, 2019
wxing1292
commented
- Supporting insertion of transfer / timer / replication task.
- Add more check on last write version and workflow state
* Supporting insertion of transfer / timer / replication task. * Add more check on last write version and workflow state
venkat1109
approved these changes
Jun 12, 2019
| if bytes.Equal(currentRow.RunID, runID) { | ||
| return &p.ConditionFailedError{Msg: fmt.Sprintf( | ||
| "Assertion on current record failed failed. Current run ID was %v, expected %v", | ||
| currentRow.RunID, |
There was a problem hiding this comment.
this log is misleading - expected and got will always be same - I think you want to return error saying that the records are expected to be different but they are same
| @@ -368,19 +368,28 @@ type ( | |||
|
|
|||
| // InternalResetMutableStateRequest is used to reset workflow execution state for Persistence Interface | |||
| InternalResetMutableStateRequest struct { | |||
| PrevRunID string | |||
| // previous workflow information | |||
| PrevRunID string | |||
There was a problem hiding this comment.
Does it make sense to create a separate persistence type for a "WorkflowRun" - that contains (runID, lastWriteVersion, state) ? Looks like these params are needed / passed everywhere for assertion.
There was a problem hiding this comment.
created an issue for this: #2013
| @@ -1880,23 +1885,92 @@ func createTimerTasks( | |||
| return nil | |||
| } | |||
|
|
|||
| func assertAndUpdateCurrentExecution(tx sqldb.Tx, shardID int, domainID sqldb.UUID, workflowID string, newRunID sqldb.UUID, previousRunID sqldb.UUID, | |||
| func assertNotCurrentExecution(tx sqldb.Tx, shardID int, domainID sqldb.UUID, workflowID string, runID sqldb.UUID) error { | |||
There was a problem hiding this comment.
I don't see this being used anywhere, do you need this ?
There was a problem hiding this comment.
this is from the 3+DC branch, probably leaked by rebase
i will remove this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.