Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildkite: generate docker image with tag master on every merge #1983

Merged
merged 5 commits into from
Jun 11, 2019
Merged

buildkite: generate docker image with tag master on every merge #1983

merged 5 commits into from
Jun 11, 2019

Conversation

venkat1109
Copy link
Contributor

  • Credentials for docker login are stored in s3
  • Added script to kickoff docker image push on every build
  • Script does work only after the commit is landed in master

@shreyassrivatsan shreyassrivatsan self-requested a review June 10, 2019 23:12
@venkat1109 venkat1109 marked this pull request as ready for review June 11, 2019 14:01
@venkat1109 venkat1109 requested a review from meiliang86 June 11, 2019 14:01
@venkat1109 venkat1109 merged commit d14a6c8 into cadence-workflow:master Jun 11, 2019
@venkat1109 venkat1109 deleted the v_docker_push branch June 11, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxing1292 wxing1292 wxing1292 left review comments

@shreyassrivatsan shreyassrivatsan Awaiting requested review from shreyassrivatsan

@meiliang86 meiliang86 Awaiting requested review from meiliang86

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@venkat1109 @wxing1292 @shreyassrivatsan