Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Wenquan Xing committed Feb 16, 2018
1 parent 0fb3728 commit d0cd134
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions service/history/transferQueueProcessor.go
Original file line number Diff line number Diff line change
Expand Up @@ -229,14 +229,11 @@ func (t *transferQueueProcessorImpl) processTransferTasks(tasksCh chan<- *persis
return
}

// here we may have a serious bug
// the transfer tasks are not guaranteed to be executed in serious.
// since there are multiple workers polling from this task channel
// so if one workflow, reports a serious of decitions, one depend on another,
// so if one workflow, reports a series of decitions, one depend on another,
// e.g. 1. start child workflow; 2. signal this workflow, the execution order
// is not guatanteed. so, client can experience weird situation.
// one way of solving this is to send all tasks of a workflow to one worker,
// i.e. do a workflow ID -> worker mapping
// is not guatanteed.
for _, tsk := range tasks {
tasksCh <- tsk
}
Expand Down

0 comments on commit d0cd134

Please sign in to comment.