subscription channel size change

cadence-workflow · Oct 14, 2024 · c9db53b · c9db53b
1 parent 25f7422
commit c9db53b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/common/membership/hashring.go b/common/membership/hashring.go
@@ -213,7 +213,7 @@ func (r *ring) notifySubscribers(msg ChangedEvent) {
 		select {
 		case ch <- &msg:
 		default:
-			r.logger.Error("subscriber notification failed", tag.Name(name))
+			r.logger.Warn("subscriber notification failed", tag.Name(name))
 		}
 	}
 }

diff --git a/common/rpc/factory.go b/common/rpc/factory.go
@@ -178,7 +178,7 @@ func (d *FactoryImpl) GetMaxMessageSize() int {
 func (d *FactoryImpl) Start(peerLister PeerLister) error {
 	// subscribe to membership changes and notify outbounds builder for peer updates
 	d.peerLister = peerLister
-	ch := make(chan *membership.ChangedEvent, 1000)
+	ch := make(chan *membership.ChangedEvent, 1)
 	if err := d.peerLister.Subscribe(d.serviceName, factoryComponentName, ch); err != nil {
 		return fmt.Errorf("rpc factory failed to subscribe to membership updates: %v", err)
 	}