check if workflow is closed when processing sticky timeout timer (#458)

cadence-workflow · Dec 12, 2017 · c844eb7 · c844eb7
1 parent 9314ff5
commit c844eb7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/service/history/timerQueueProcessor.go b/service/history/timerQueueProcessor.go
@@ -783,8 +783,8 @@ Update_History_Loop:
 			t.metricsClient.IncCounter(metrics.TimerTaskDecisionTimeoutScope, metrics.ScheduleToStartTimeoutCounter)
 			// decision schedule to start timeout only apply to sticky decision
 			// check if scheduled decision still pending and not started yet
-			if isPending && di.Attempt == task.ScheduleAttempt && di.StartedID == emptyEventID &&
-				msBuilder.isStickyTaskListEnabled() {
+			if isPending && di.Attempt == task.ScheduleAttempt && msBuilder.isWorkflowExecutionRunning() &&
+				di.StartedID == emptyEventID && msBuilder.isStickyTaskListEnabled() {
 				timeoutEvent := msBuilder.AddDecisionTaskScheduleToStartTimeoutEvent(scheduleID)
 				if timeoutEvent == nil {
 					// Unable to add DecisionTaskTimedout event to history