Use domain name in completeActivityByID instead of domainID (#520)

* Use domain name in completeActivityByID instead of domainID * rebase
cadence-workflow · Jan 23, 2018 · b9c8eef · b9c8eef
1 parent 4725ace
commit b9c8eef
Show file tree

Hide file tree

Showing 5 changed files with 112 additions and 93 deletions.
diff --git a/.gen/go/shared/idl.go b/.gen/go/shared/idl.go
diff --git a/.gen/go/shared/types.go b/.gen/go/shared/types.go
diff --git a/common/cache/domainCache.go b/common/cache/domainCache.go
@@ -46,6 +46,7 @@ type (
 	DomainCache interface {
 		GetDomain(name string) (*persistence.DomainInfo, *persistence.DomainConfig, error)
 		GetDomainByID(id string) (*persistence.DomainInfo, *persistence.DomainConfig, error)
+		GetDomainID(name string) (string, error)
 	}
 
 	domainCache struct {
@@ -95,6 +96,15 @@ func (c *domainCache) GetDomainByID(id string) (*persistence.DomainInfo, *persis
 	return c.getDomain(id, id, "", c.cacheByID)
 }
 
+// GetDomainID retrieves domainID by using GetDomain
+func (c *domainCache) GetDomainID(name string) (string, error) {
+	info, _, err := c.GetDomain(name)
+	if err != nil {
+		return "", err
+	}
+	return info.ID, nil
+}
+
 // GetDomain retrieves the information from the cache if it exists, otherwise retrieves the information from metadata
 // store and writes it to the cache with an expiry before returning back
 func (c *domainCache) getDomain(key, id, name string, cache Cache) (*persistence.DomainInfo, *persistence.DomainConfig, error) {

diff --git a/idl/github.com/uber/cadence/shared.thrift b/idl/github.com/uber/cadence/shared.thrift
@@ -866,7 +866,7 @@ struct RespondActivityTaskCanceledRequest {
 }
 
 struct RespondActivityTaskCompletedByIDRequest {
-  10: optional string domainID
+  10: optional string domain
   20: optional string workflowID
   30: optional string runID
   40: optional string activityID
@@ -875,7 +875,7 @@ struct RespondActivityTaskCompletedByIDRequest {
 }
 
 struct RespondActivityTaskFailedByIDRequest {
-  10: optional string domainID
+  10: optional string domain
   20: optional string workflowID
   30: optional string runID
   40: optional string activityID
@@ -885,7 +885,7 @@ struct RespondActivityTaskFailedByIDRequest {
 }
 
 struct RespondActivityTaskCanceledByIDRequest {
-  10: optional string domainID
+  10: optional string domain
   20: optional string workflowID
   30: optional string runID
   40: optional string activityID