add handling of child workflow ID reuse logic (#500)

cadence-workflow · Jan 12, 2018 · b98524b · b98524b
1 parent 5121974
commit b98524b
Show file tree

Hide file tree

Showing 5 changed files with 117 additions and 41 deletions.
diff --git a/.gen/go/shared/idl.go b/.gen/go/shared/idl.go
diff --git a/.gen/go/shared/types.go b/.gen/go/shared/types.go
diff --git a/idl/github.com/uber/cadence/shared.thrift b/idl/github.com/uber/cadence/shared.thrift
@@ -306,6 +306,7 @@ struct StartChildWorkflowExecutionDecisionAttributes {
   70: optional i32 taskStartToCloseTimeoutSeconds
   80: optional ChildPolicy childPolicy
   90: optional binary control
+  100: optional WorkflowIdReusePolicy workflowIdReusePolicy
 }
 
 struct Decision {
@@ -538,6 +539,7 @@ struct StartChildWorkflowExecutionInitiatedEventAttributes {
   80:  optional ChildPolicy childPolicy
   90:  optional binary control
   100: optional i64 (js.type = "Long") decisionTaskCompletedEventId
+  110: optional WorkflowIdReusePolicy workflowIdReusePolicy
 }
 
 struct StartChildWorkflowExecutionFailedEventAttributes {

diff --git a/service/history/historyBuilder.go b/service/history/historyBuilder.go
@@ -707,6 +707,7 @@ func (b *historyBuilder) newStartChildWorkflowExecutionInitiatedEvent(decisionTa
 	attributes.ChildPolicy = common.ChildPolicyPtr(*startAttributes.ChildPolicy)
 	attributes.Control = startAttributes.Control
 	attributes.DecisionTaskCompletedEventId = common.Int64Ptr(decisionTaskCompletedEventID)
+	attributes.WorkflowIdReusePolicy = startAttributes.WorkflowIdReusePolicy
 	historyEvent.StartChildWorkflowExecutionInitiatedEventAttributes = attributes
 
 	return historyEvent

diff --git a/service/history/transferQueueProcessor.go b/service/history/transferQueueProcessor.go
@@ -634,7 +634,8 @@ func (t *transferQueueProcessorImpl) processStartChildExecution(task *persistenc
 					ExecutionStartToCloseTimeoutSeconds: common.Int32Ptr(*attributes.ExecutionStartToCloseTimeoutSeconds),
 					TaskStartToCloseTimeoutSeconds:      common.Int32Ptr(*attributes.TaskStartToCloseTimeoutSeconds),
 					// Use the same request ID to dedupe StartWorkflowExecution calls
-					RequestId: common.StringPtr(ci.CreateRequestID),
+					RequestId:             common.StringPtr(ci.CreateRequestID),
+					WorkflowIdReusePolicy: attributes.WorkflowIdReusePolicy,
 				},
 				ParentExecutionInfo: &history.ParentExecutionInfo{
 					DomainUUID: common.StringPtr(domainID),