-
Notifications
You must be signed in to change notification settings - Fork 812
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
What changed? Refactored the error test in the proto mapper Added test to make sure all fields are set in the test errors (if not, the check will pass, even though data would be lost). Added tests for the thrift mapper Why? Make sure data is preserved in the mappings How did you test it? It's a test in itself. Potential risks Release notes Documentation Changes
- Loading branch information
Showing
5 changed files
with
160 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| // Copyright (c) 2021 Uber Technologies Inc. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in all | ||
| // copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| // SOFTWARE. | ||
|
|
||
| package thrift | ||
|
|
||
| import ( | ||
| "errors" | ||
| "reflect" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "go.uber.org/yarpc/yarpcerrors" | ||
|
|
||
| "github.com/uber/cadence/common/types/testdata" | ||
| ) | ||
|
|
||
| func TestErrors(t *testing.T) { | ||
| for _, err := range testdata.Errors { | ||
| name := reflect.TypeOf(err).Elem().Name() | ||
| t.Run(name, func(t *testing.T) { | ||
| // Test that the mappings does not lose information | ||
| assert.Equal(t, err, ToError(FromError(err))) | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestNilMapsToNil(t *testing.T) { | ||
| assert.Nil(t, FromError(nil)) | ||
| assert.Nil(t, ToError(nil)) | ||
| } | ||
|
|
||
| func TestFromUnknownErrorMapsToItself(t *testing.T) { | ||
| err := errors.New("unknown error") | ||
| assert.Equal(t, err, FromError(err)) | ||
| } | ||
|
|
||
| func TestToUnknownErrorMapsToItself(t *testing.T) { | ||
| err := yarpcerrors.DeadlineExceededErrorf("timeout") | ||
| assert.Equal(t, err, ToError(err)) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| // The MIT License (MIT) | ||
|
|
||
| // Copyright (c) 2017-2020 Uber Technologies Inc. | ||
|
|
||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in all | ||
| // copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| // SOFTWARE. | ||
|
|
||
| package testdata | ||
|
|
||
| import ( | ||
| "reflect" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestAllFieldsSetInTestErrors(t *testing.T) { | ||
| for _, err := range Errors { | ||
| name := reflect.TypeOf(err).Elem().Name() | ||
| t.Run(name, func(t *testing.T) { | ||
| // Test all fields are set in the error | ||
| assert.True(t, checkAllIsSet(err)) | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func checkAllIsSet(err error) bool { | ||
| // All the errors are pointers, so we get the value with .Elem | ||
| errValue := reflect.ValueOf(err).Elem() | ||
|
|
||
| for i := 0; i < errValue.NumField(); i++ { | ||
| field := errValue.Field(i) | ||
|
|
||
| // IsZero checks if the value is the default value (e.g. nil, "", 0 etc) | ||
| if field.IsZero() { | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| return true | ||
| } |