Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support feature flags in java client #619

Merged

Conversation

demirkayaender
Copy link
Contributor

@demirkayaender demirkayaender commented Jun 18, 2021

What changed?
Similar to cadence-workflow/cadence-go-client#1103 change in go client, this PR introduces feature flags to java client so customers using java can enable/disable some features.

Why?
Without this change, customers won't be able to turn on some features.

How did you test it?

USE_DOCKER_SERVICE=true ./gradlew test --tests *testSignalingCompletedWorkflow* // with real server

./gradlew test --tests *testSignalingCompletedWorkflow*

Also tested with java samples

Potential risks

@demirkayaender demirkayaender requested a review from a team June 18, 2021 19:11
@demirkayaender
Copy link
Contributor Author

Failure is from the integration test using older server Docker images which doesn't support the new error. On Monday, I will ask how to update the server version.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 862

  • 9 of 42 (21.43%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 71.175%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/uber/cadence/serviceclient/ClientOptions.java 4 5 80.0%
src/main/java/com/uber/cadence/internal/testservice/TestWorkflowService.java 0 2 0.0%
src/main/java/com/uber/cadence/internal/sync/TestActivityEnvironmentInternal.java 0 3 0.0%
src/main/java/com/uber/cadence/internal/sync/TestWorkflowEnvironmentInternal.java 0 3 0.0%
src/main/java/com/uber/cadence/serviceclient/WorkflowServiceTChannel.java 5 29 17.24%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/serviceclient/ClientOptions.java 1 55.13%
Totals Coverage Status
Change from base Build 858: -0.1%
Covered Lines: 10699
Relevant Lines: 15032

💛 - Coveralls

@demirkayaender demirkayaender requested a review from a team August 24, 2021 15:57
@demirkayaender demirkayaender merged commit 8c61213 into cadence-workflow:master Aug 24, 2021
@demirkayaender demirkayaender deleted the feature_flags_java branch August 24, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants