Support tuples as keys for get_all/put_all callbacks in Redis/Client cluster #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Nebulex README Quickstart example, there are cases where the keys are Elixir tuples.
Tuples as keys work perfectly fine in
nebulex_redis_adapter
with astandalone
Redis instance. They also work fine withnebulex_redis_adapter
inredis_cluster
/client_cluster
mode forget
/put
callbacks.However,
get_all
andput_all
callbacks don't work properly with tuples as keys.When running those callbacks with tuples as keys,
CROSSLOT
errors often occur.Example:
This appears because the
group_keys_by_hash_slot
function takes anEnum.t()
of:get_all
OR
put_all
The change in this Pull Request aims to resolve this issue by specifying an atom (
:keys
/:tuples
) as an argument to differentiate between the two cases.