Add support for stats via Nebulex.Telemetry.StatsHandler #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabol
reviewed
May 19, 2021
There was a problem hiding this comment.
LGTM 👌 . The only missing thing is to add a test, it can be a simple test just to confirm the stats work, and also this callback is covered. BTW, to keep it in mind, I think the stat :expirations is not going to be possible to update it since it is not possible to know if a key was expired or it does not exist from Redis API (perhaps we can check), but just to keep it inn mind, this can be handled if a separate issue if there is a way to do it.
How's that now? 😉 |
cabol
reviewed
May 19, 2021
simoncocking
force-pushed
the
feat/add-stats
branch
from
515d9cf to
8cc6f25
Compare
cabol
approved these changes
May 20, 2021
cabol
reviewed
May 20, 2021
cabol
reviewed
May 20, 2021
cabol
approved these changes
May 20, 2021
cabol
reviewed
May 20, 2021
simoncocking
force-pushed
the
feat/add-stats
branch
from
3136124 to
cb25159
Compare
simoncocking
force-pushed
the
feat/add-stats
branch
from
cb25159 to
9d223d4
Compare
cabol
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for emitting stats via
Nebulex.Telemetry.StatsHandler, leveraging the Telemetry span events added in v2.1.0. Resolves #28.