Hotfix: bcrypt symbol lookup error #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using admin privileges to force merge this PR since it is a hotfix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to
bcrypt@3caused the app to crash with the following error:.meteor/heroku_build/bin/node: symbol lookup error: /app/.meteor/heroku_build/app/programs/server/npm/node_modules/bcrypt/lib/binding/bcrypt_lib.node: undefined symbol: ...See a discussion of the problem here: kelektiv/node.bcrypt.js#656
An apparent fix is to update to node 8.12 so that the N-API bindings are compatible between bcrypt and node. However, this does not seem to work in all cases when deploying to Heroku.
Because we are not taking advantage of any new bcrypt features and because no security updates have apparently been made to the library, I am simply rolling back the bcrypt version to what we had before the recent
/ticketsAPI update.