Fix hashing in bullet-prespawn example #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bullet-prespawn example spawns 2 PreSpawned objects in the same tick.
These 2 bullets have the same exact hash since they have the same component list + spawn tick.
I think I added this to show that lightyear doesn't panic even with multiple prespawned entities with the same hash exist.
However this was causing a lot of rollbacks since the left bullet on the server might match with the right bullet on the client!
In general we might never want to have this behavior. Maybe it's better to panic if this happens, to let users make sure that the hashes don't collide? For now I'll still support it but issue a warning if this happens.
Fixes #178