Implemented delete button

[ghost]

I have implemented the delete button

[c-w]

Thanks for the PR. PTAL CI failure.

Additionally, changes should be backwards compatible to avoid surprising existing users with a UI change when they update; so I suggest adding a config option that turns on the delete buttons instead of having them enabled by default.

Lastly, could you also add a nightwatch test for the new functionality. Thank you!

[ghost]

Okay, Clemens, I will manage to get that done by the next weekend

[ghost]

I have implemented everything that you required me.
Now it can be set to see the button option through the option displayDeleteButtonOnHistory in the options object.
I also have implemented the tests in NightWatch.js

[ghost]

Clemens, hello... Have you teted out the delete button?
Is everything ok with it?

[ghost]

Clemens, I solved this issue by adding an inline style for the container div when using the deleteButton, ok?
In the line 341 of the mathquill4quill.js file
container.style.width = "318px";

[ghost]

Is everythin correct now, @c-w?

[c-w]

Apologies, I haven't gotten around to re-review this yet. I'll take a look ASAP.

[c-w]

Apologies for the delay in reviewing this. To speed up a merge, I took the liberty to make a few changes. Take a look at my patch with the suggested diff and git apply it if you're satisfied with the fixes.

[ghost]

Hey, Clemens, I applied most of those changes... Expect for the index
We actually have to look for each element we want to delete with const index = history.indexOf(element), it doesn't work through the index element of the array as you can see in the video attached down bellow

mathquill4quill.Demo.-.Google.Chrome.2022-11-05.13-27-08.mp4

[c-w]

Thanks for the changes. PTAL CI failure (you can also run it locally with npm run lint, probably a good idea as for some reason Github asks me to continuously re-approve the CI run) and the nitpicks regarding keeping the git history clean. Thank you.

[c-w]

More issues from CI. I think I listed them all, but to be sure do run npm run lint locally after making the changes so that we can get this merged in the next round. Alternatively you can also allow edits by maintainers on the PR so that I can make these nitty changes directly and get it released. Thank you.

[ghost]

More issues from CI. I think I listed them all, but to be sure do run npm run lint locally after making the changes so that we can get this merged in the next round. Alternatively you can also allow edits by maintainers on the PR so that I can make these nitty changes directly and get it released. Thank you.

I have given you the right to edit my pull request, @c-w

[c-w]

Thank you for the contribution!

[c-w]

This has been released in v2.4.0