In merge_rawnc, move 'badfiles' into the same for-loop as 'goodfiles' #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is for consistency with a previous fix to the 'goodfiles' variable, which was moved into a different for-loop in order to properly handle the situation where we have .pld files but no .gld files. The 'badfiles' variable is used for logging, and will now log all bad files at the end of the processing loop.
jklymak
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is for consistency with a previous fix to the 'goodfiles'
variable, which was moved into a different for-loop in order to
properly handle the situation where we have .pld files but no .gld
files. The 'badfiles' variable is used for logging, and will now
log all bad files at the end of the processing loops.