Host-wasmtime-rust: import functions are able to Trap execution #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 19, 2022 13:26
this is implied since main is the default branch, and means that in other places that depend on the default branch, the wasmtime brought in by these crates is not the same dependency additionally, drop the dep on wasmtime-wasi altogether, it is not used.
to handle `*.wit.md` files correctly.
just to functions with a single result which is a result<a, e> and e is a defined type. This ensures we can generate the std::error::Error impl for those types, otherwise we cant wrap them up into an anyhow::Error.
alexcrichton
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Looks good to me!
I think CI can be fixed by copying this block for the new test.
At least that's how existing tests don't trip up over this error. It may also be fixable by using #[cfg] on the include! macro invocation so only run the include! on wasm which would avoid the need to update Cargo.toml as well (which would be nice!)
added 2 commits
October 21, 2022 09:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test https://github.com/pchickey/wit-bindgen/blob/wasmtime_trapping/tests/runtime/results/host.rs demonstrates how this behavior works.