Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cap-std 3.3.0. #9307

Merged

Conversation

sunfishcode
Copy link
Member

cap-std 3.3.0 contains bytecodealliance/cap-std#366, which fixes #9272, which is about the handling of .. in symlink destinations.

cap-std 3.3.0 contains bytecodealliance/cap-std#366, which fixes bytecodealliance#9272,
which is about the handling of `..` in symlink destinations.
@sunfishcode sunfishcode requested a review from a team as a code owner September 24, 2024 22:53
@sunfishcode sunfishcode requested review from elliottt and removed request for a team September 24, 2024 22:53
@sunfishcode
Copy link
Member Author

sunfishcode commented Sep 24, 2024

This PR doesn't involve pulley-interpreter at all, however cargo-vet in CI appears to be failing with:

Vetting Failed!

1 unvetted dependencies:
  pulley-interpreter:0.2.1 missing ["safe-to-deploy"]

recommended audits for safe-to-deploy:
    Command                                        Publisher         Used By                               Audit Size
    cargo vet diff pulley-interpreter 0.1.0 0.1.1  wasmtime-publish  wasmtime, wasmtime-cli, and 3 others  2 files changed, 3 insertions(+), 3 deletions(-)
      NOTE: this project trusts wasmtime-publish - consider cargo vet trust pulley-interpreter wasmtime-publish

@alexcrichton
Copy link
Member

There's something I think none of us understand about cargo-vet and how it relates to (a) adding new crates in the workspace and (b) causing vets to fail after the crate was actually published. The weird part is we've even landed PRs today after the publication of Wasmtime 25, so I'm not sure why this PR ended up being the victim...

@alexcrichton alexcrichton added this pull request to the merge queue Sep 25, 2024
Merged via the queue into bytecodealliance:main with commit 1af294e Sep 25, 2024
39 checks passed
@sunfishcode sunfishcode deleted the sunfishcode/update-cap-std branch September 25, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper resolution of .. components in symlinks
3 participants