Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #81

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Update README.md #81

merged 1 commit into from
Mar 28, 2019

Conversation

mcculley
Copy link
Contributor

Small spelling fix.

Small spelling fix.
@sunfishcode
Copy link
Member

Thanks!

@sunfishcode sunfishcode merged commit 1d4b704 into bytecodealliance:master Mar 28, 2019
@sunfishcode sunfishcode mentioned this pull request Mar 31, 2019
kubkon pushed a commit that referenced this pull request Nov 7, 2019
* Fix fd_readdir on BSD-style nixes

The fix was tested on Darwin-XNU and FreeBSD. The change introduces
thread-safe cache of (RawFd, *mut libc::DIR) pairs so that
libc::fdopendir syscall is called only once when invoking fd_readdir
for the first time, and then the pointer to the directory stream,
*mut libc::DIR, is reused until the matching raw file descriptor
is closed.

This fix allows then correct use (and matching to the implementation
on Linux kernels) of libc::seekdir and libc::rewinddir to seek through
and rewind the existing directory stream, *mut libc::DIR, which
otherwise seems to be reset/invalidated every time libc::fdopendir
is called (unlike on Linux, where this behaviour is not observed).

* Store dir stream as part of the FdEntry's Descriptor

* Move bsd specifics into separate module

* Add todo comments and fix formatting

* Refactor int conversions

* Emphasise in debug logs that we're looking at fd_readdir entry

* Change visibility of FdEntry and related to public-private

* Rewrite creating DirStream for the first time
grishasobol pushed a commit to grishasobol/wasmtime that referenced this pull request Nov 29, 2021
* Publish with_externvals constructor.
* Add examples to Signature::new.
* Use Iterators for ExternVal imports
howjmay pushed a commit to howjmay/wasmtime that referenced this pull request Jan 24, 2022
* Update with Wasmtime's new C API

This commit updates this repository to use Wasmtime's new C API as
specified by [RFC 11]. This is a breaking change for this API and
notably requires that a `Storelike` object is now passed in for many
functions, serving as the `Store` context for that method. The
implementation of memory management, however, has been greatly
simplified, now that objects within a `Store` no longer need
destructors. This should improve performance and also help avoid
reclaiming memory only at odd times.

[RFC 11]: bytecodealliance/rfcs#11

* Try fixing bazel build

* Cancel in-flight jobs on CI
howjmay pushed a commit to howjmay/wasmtime that referenced this pull request Jan 24, 2022
* Add build/include/wasmtime

Following the update to Wasmtime's new C API in bytecodealliance#81, the header files are now not
only in build/local, but also in build/local/wasmtime.

This commit adds the directory "build/include/wasmtime" as a valid empty go
package, like it was done in bytecodealliance#45 for the other build directories.

It also addapts `ci/local.sh` to:
- copy the additional header files in build/include/wasmtime
- stop this script from removing the "empty.go" files.

* Import build packages + add CI test for vendoring

- Import build packages, to prevent `go mod vendor` from pruning the build
  directories;
- Update download-wasmtime.py to re-create the "empty.go" files and keep
  the Go packages in "build"
- Add a CI test to check that wasmtime-go can be used by Go projects using
  dependency vendoring

* Fix for Bazel
pchickey added a commit to pchickey/wasmtime that referenced this pull request May 16, 2023
…ance#81)

this is broken at the moment and is getting in the way of testing more
interesting bits of functionality. we'll re-enable it once other stuff
is working.
pchickey added a commit to pchickey/wasmtime that referenced this pull request May 16, 2023
* Revert "wasi-tests: add configuration to ignore rights readback (bytecodealliance#81)"

This reverts commit d006b1b.

* wasi-tests: pull in all changes from upstream which remove support for rights

bytecodealliance#6265

note, im leaving out upstream changes to fd_readdir which are from bytecodealliance#6163, which requires porting the rest of that PR into this repo

* remove rights readback variable from test runner

* rustfmt

* delete path_open_read_without_rights test

which was deleted upstream
dhil added a commit to dhil/wasmtime that referenced this pull request Jan 26, 2024
This patch replaces the bespoke "WasmFX CI workflow" with the workflows of upstream. The necessary changes to the workflow files are minimal.

However, using their workflows did show that our lockfiles are out of sync quite a bit, which was mainly caused by uses of `num_enum` and `regex` crates. Both uses seem unnecessary to me, however, the debug printing does make internal use of `regex`, and therefore I have disabled it until we have implemented a suitable substitute for the crate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants